Reviewed 86 of 86 files at r1, 27 of 27 files at r2, 15 of 15 files at r3, 7 of 7 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @olmoh)

desktop/packages/mullvad-vpn/src/main/index.ts line 860 at r2 (raw file):

      if (Object.values(links).find((link) => url.startsWith(link))) {
        await shell.openExternal(url);
      }

If the links are converted to an enum, wouldn't it be possible to type openUrl to only accept valid links instead of any string? Then this function would not need to check if the link is valid by looking up if url exists in links 😊

Code quote:

    IpcMainEventChannel.app.handleOpenUrl(async (url) => {
      if (Object.values(links).find((link) => url.startsWith(link))) {
        await shell.openExternal(url);
      }

Reviewed 31 of 31 files at r6, 11 of 11 files at r7, 21 of 21 files at r8, 3 of 3 files at r9, 4 of 4 files at r10, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @olmoh)

Reviewable status: 56 of 90 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

desktop/packages/mullvad-vpn/src/main/index.ts line 860 at r2 (raw file):

Great suggestion, I have added typing to the openUrl and related functions 😄

Reviewed 31 of 31 files at r11, 14 of 14 files at r12, 22 of 22 files at r13, 4 of 6 files at r14, 2 of 5 files at r15, 9 of 15 files at r17, 7 of 7 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 1 of 1 files at r19, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved